Someone can help me fix BATTLE_READY

[Exile03]

hey man really i not understand why crash client STOP working when i try 1x1 and 1x8 pve
i make code same u send me.
i think locate call in Room.java not working this call
Room.java

public ConcurrentHashMap<Long, Player> getReadyPlayers() {
// TODO Auto-generated method stub
return ReadyPlayers;
}

[PROGRAMMATOR]

Of course it will be a mistake. Where is the realisation getReadyPlayers()?

[SRC="java"]public List<Player> getReadyPlayerList()
{
List<Player> readyPlayerList = new ArrayList<Player>();

for (Player player : _playerList)
{
if (player.hasSlotState(PlayerSlotState.READY))
{
readyPlayerList.add(player);
}
}

return readyPlayerList;
}[/SRC]


What a countReadyPlayer do you have, that is always equal to 0, dont you understand, that there must be the number of players who a ready to connect to battle? I wrote upstreams in comment that the stucture is corrected, but yours is not writeH(countReadyPlayer) instead of writeC(countReadyPlayer).

slotId is always equal to 0, if it had to contain player slot in the room. The same is about skills. You should not just thoughtlessly copy that, what I have written.

[SRC="java"]writeC((byte)_room.getReadyPlayerList().size());

for (Player player : _room.getReadyPlayerList())
{
writeC(player.slotId());

// 4 * 5 (character items)

// 4 * 6 (weapon items)

writeC(player.skill().first());
writeC(player.skill().second());
writeC(player.skill().third());
}[/SRC]

[Exile03]

This locate is correct code man?

Код:

public List<Player> getReadyPlayerList()
{
    List<Player> readyPlayerList = new ArrayList<Player>();

    for (Player player : _playerList)
    {
        if (player.[B][color=Blue]hasSlotState[/color][/B](SlotState.SLOT_STATE_BATTLE_READY))
        {
            readyPlayerList.add(player);
        }
    }

    return  readyPlayerList;
}
Code: Java

]

[PROGRAMMATOR]

This is just an example. You must write it yourself.

[SRC="csharp"]public enum SlotState
{
EMPTY,
CLOSE,
SHOP,
INFO,
CLAN,
INVENTORY,
LOTTERY,
NORMAL,
READY,
LOAD,
RENDEZVOUS,
PRESTART,
BATTLE_READY,
BATTLE_NOW,
}[/SRC]

[Exile03]

this code same code java

public enum SlotState {
SLOT_STATE_EMPTY, //
SLOT_STATE_CLOSE, //
SLOT_STATE_SHOP, //
SLOT_STATE_INFO, //
SLOT_STATE_CLAN, //
SLOT_STATE_INVENTORY, //
SLOT_STATE_OUTPOST, //
SLOT_STATE_NORMAL, //
SLOT_STATE_READY, //
SLOT_STATE_LOAD, //
SLOT_STATE_RENDEZVOUS, //
SLOT_STATE_PRESTART, //
SLOT_STATE_BATTLE_READY, //
SLOT_STATE_BATTLE;

}

[PROGRAMMATOR]

I have written to be safe, if you do not have slot states.

[Exile03]

[PROGRAMMATOR]

PROTOCOL_BATTLE_READYBATTLE_REQ

[SRC="java"]if (player.hasSlotState(SlotState.NORMAL))
{
player.setSlotState(SlotState.READY);
}
else
{
player.setSlotState(SlotState.NORMAL);
}
[/SRC]


Player.java

[SRC="java"]private SlotState slotState;

public void setSlotState(SlotState state)
{
slotState = state;
}

public boolean hasSlotState(SlotState state)
{
return slotState == state;
}
[/SRC]


If I correctly understood your English. kappa

[Exile03]

sorry my english not very good man:inlove:


i need try fix this problem now i need try remake code READY BATTLE for call player
for try use same u talked
why my READY call RoomSlot
you call Player is very different

[src=java]public class CM_BATTLE_READY_REQ extends ClientPacket {

public CM_BATTLE_READY_REQ (int opcode) {
super(opcode);
}

@Override
public void readImpl() {
}

@Override
public void runImpl() {
final Room room = getConnection().getRoom();
if(room.getLeader().equals(getConnection().getPlayer())) {
if(room.isFigth() == 0) {
room.setFigth(1);
room.setTimeLost(room.getKillTime() * 60);
room.blueTeamCount = 0;
room.redTeamCount = 0;
room.doRound = 0;
}
ThreadPoolManager.getInstance().executeTask(new Runnable() {
@Override
public void run() {
for(Player member : getConnection().getRoom().getPlayers().values()) {
RoomSlot slot = room.getRoomSlotByPlayer(member);

if(slot.getState() == SlotState.SLOT_STATE_READY && !room.getLeader().equals(member)) {

slot.setState(SlotState.SLOT_STATE_LOAD);
member.getConnection().sendPacket(new SM_BATTLE_READY(room, getConnection().getPlayer()));
} else if(room.getLeader().equals(member)) {
slot.setState(SlotState.SLOT_STATE_LOAD);
member.getConnection().sendPacket(new SM_BATTLE_READY(room, member));
}
}
}
});
} else {
RoomSlot slotLeader = room.getRoomSlotByPlayer(room.getLeader());
RoomSlot slot = room.getRoomSlotByPlayer(getConnection().getPlayer());

if(slotLeader.getState() == SlotState.SLOT_STATE_LOAD || slotLeader.getState() == SlotState.SLOT_STATE_RENDEZVOUS || slotLeader.getState() == SlotState.SLOT_STATE_PRESTART || slotLeader.getState() == SlotState.SLOT_STATE_BATTLE_READY || slotLeader.getState() == SlotState.SLOT_STATE_BATTLE) {
slot.setState(SlotState.SLOT_STATE_LOAD);
sendPacket(new SM_BATTLE_READY(room, getConnection().getPlayer()));
}
if(slot.getState() == SlotState.SLOT_STATE_READY) {
slot.setState(SlotState.SLOT_STATE_NORMAL);
} else if(slot.getState() == SlotState.SLOT_STATE_NORMAL) {
slot.setState(SlotState.SLOT_STATE_READY);
}
}
ThreadPoolManager.getInstance().executeTask(new Runnable() {
@Override
public void run() {
for(Player member : getConnection().getRoom().getPlayers().values()) {
member.getConnection().sendPacket(new SM_ROOM_INFO(room));
}
}
});
}

}[/src]

[Exile03]

Man i have other question i very try fix this camera player round finish for he play
but not sucess no work i very ty your method in my READY BATTEL but not understand well your




this is my CM_BATTLE_READY_REQ code Java you know in he locate for fix this bug?
[src=java]public class CM_BATTLE_READY_REQ extends ClientPacket {

public CM_BATTLE_READY_REQ (int opcode) {
super(opcode);
}

@Override
public void readImpl() {
}

@Override
public void runImpl() {
final Room room = getConnection().getRoom();
if(room.getLeader().equals(getConnection().getPlayer())) {
if(room.isFigth() == 0) {
room.setFigth(1);
room.setTimeLost(room.getKillTime() * 60);
room.blueTeamCount = 0;
room.redTeamCount = 0;
room.doRound = 0;
}
ThreadPoolManager.getInstance().executeTask(new Runnable() {
@Override
public void run() {
for(Player member : getConnection().getRoom().getPlayers().values()) {
RoomSlot slot = room.getRoomSlotByPlayer(member);

if(slot.getState() == SlotState.SLOT_STATE_READY && !room.getLeader().equals(member)) {

slot.setState(SlotState.SLOT_STATE_LOAD);
member.getConnection().sendPacket(new SM_BATTLE_READY(room, getConnection().getPlayer()));
} else if(room.getLeader().equals(member)) {
slot.setState(SlotState.SLOT_STATE_LOAD);
member.getConnection().sendPacket(new SM_BATTLE_READY(room, member));
}
}
}
});
} else {
RoomSlot slotLeader = room.getRoomSlotByPlayer(room.getLeader());
RoomSlot slot = room.getRoomSlotByPlayer(getConnection().getPlayer());

if(slotLeader.getState() == SlotState.SLOT_STATE_LOAD || slotLeader.getState() == SlotState.SLOT_STATE_RENDEZVOUS || slotLeader.getState() == SlotState.SLOT_STATE_PRESTART || slotLeader.getState() == SlotState.SLOT_STATE_BATTLE_READY || slotLeader.getState() == SlotState.SLOT_STATE_BATTLE) {
slot.setState(SlotState.SLOT_STATE_LOAD);
sendPacket(new SM_BATTLE_READY(room, getConnection().getPlayer()));
}
if(slot.getState() == SlotState.SLOT_STATE_READY) {
slot.setState(SlotState.SLOT_STATE_NORMAL);
} else if(slot.getState() == SlotState.SLOT_STATE_NORMAL) {
slot.setState(SlotState.SLOT_STATE_READY);
}
}
ThreadPoolManager.getInstance().executeTask(new Runnable() {
@Override
public void run() {
for(Player member : getConnection().getRoom().getPlayers().values()) {
member.getConnection().sendPacket(new SM_ROOM_INFO(room));
}
}
});
}

}[/src]